[#LOG4NET-32] AdoNetAppender losing first entry

Log4net

AdoNetAppender losing first entry

Created: 03/Jun/05 05:32 PM Updated: 09/Jun/05 02:15 AM

Return to search

Component/s:

Appenders

Affects Version/s:

1.2.9

Fix Version/s:

1.2.10

Time Tracking:

Not Specified

Environment:

« Hide

VB.Net 2003, .Net 1.1.4322 SP1, SQL Server 2000, Windows XP Pro

Resolution Date:

09/Jun/05 02:15 AM

Description

« Hide

AdoNetAppender is losing the first log entry, caused by the entry being discarded as the underlying buffer cycles for the first time.

Probable error at line 400 in BufferingAppenderSkeleton.cs:

if (discardedLoggingEvent != null && m_lossyEvaluator != null && m_lossyEvaluator.IsTriggeringEvent(discardedLoggingEvent))

If you don't give a lossy evaluator the event is discarded, regardless of whether the buffer is lossy or not. This line should also check if the buffer is lossy, and send the discarded event if it isn't:

if (discardedLoggingEvent != null && (!m_lossy || (m_lossyEvaluator != null && m_lossyEvaluator.IsTriggeringEvent(discardedLoggingEvent))))

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#312287	Wed Jun 08 17:13:40 UTC 2005	nicko	Fix and tests for ~~LOG4NET-32~~ AdoNetAppender losing first entry
				Files Changed
				MODIFY /logging/log4net/trunk/tests/src/log4net.Tests.csproj MODIFY /logging/log4net/trunk/tests/src/Appender/CountingAppender.cs ADD /logging/log4net/trunk/tests/src/Appender/BufferingAppenderTest.cs MODIFY /logging/log4net/trunk/src/Appender/BufferingAppenderSkeleton.cs

Nicko Cadell made changes - 09/Jun/05 02:06 AM

Field	Original Value	New Value
Assignee		Nicko Cadell [ nicko ]

[ Permlink | « Hide ]

Nicko Cadell added a comment - 09/Jun/05 02:15 AM

Fixed BufferingAppenderSkeleton to log the discarded event if in non lossy mode.

Nicko Cadell made changes - 09/Jun/05 02:15 AM

Fix Version/s		1.2.10 [ 11128 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]