[PATCH] Added ExceptionEvaluator

• Key: LOG4NET-107
• Type: New Feature
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Ron Grabowski
• Reporter: Drew Schaeffer
• Component/s: Core
• Affects Version/s: 1.2.10
• Fix Version/s: 1.2.11

Description

Added an ExceptionEvaluator class to allow buffered appenders to trigger based on the type of LoggingEvent.ExceptionObject. By setting the TiggerOnSubclass property the evaluator will trigger on types that are of the same type or subclasses of ExceptionType.

Comments

[Drew Schaeffer]

built against svn revision 488382

[Drew Schaeffer]

ExceptionEvaluator.cs adds an evaluator that allows buffered appenders to be triggered based on the type of LoggingEvent.ExceptionObject

[Ron Grabowski]

Why isn't ExceptionType of type Exception:

/// <summary>
/// The type that triggers this evaluator.
/// </summary>
public Exception ExceptionType
{
get { return m_type; }
set { m_type = value; }
}

We know from the Exception property on LoggingEvent that the type must be at least Exception.

+1 for making the signature "public Exception ExceptionType".

[Drew Schaeffer]

It seemed intuitive to make ExceptionType of type Type. Otherwise, when creating an ExceptionEvaluator you would have to set ExceptionType to an instance of the type of exception you want to trigger on. ie

ExceptionEvaluator eval = new ExceptionEvaluator();
eval.ExceptionType = new ApplicationException();

This would certainly work but ExceptionEvaluator.IsTriggeringEvent would still be comparing the type. ie

m_type.GetType() == loggingEvent.ExceptionObject.GetType()

So if the type of exception is what is being compared why not have ExceptionType be of type Type?

[Ron Grabowski]

Doh! You're absolutely correct. I must have been thinking about something else when I wrote that.

[Ron Grabowski]

Fixed in r489241: Added ExceptionEvaluator that triggers a BufferingAppenderSkeleton to flush its buffer when a certain Exception is detected.