[LOG4J2-2443] Consistent validation exceptions

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Log4j-Audit 1.0.0
• Fix Version/s: Log4j-Audit 1.0.1
• Component/s: Log4j-Audit
• Assignee: Unassigned
• Reporter: Andrei Ivanov
• Created: 12/Sep/18 14:43
• Updated: 01/Oct/18 09:11
• Resolved: 30/Sep/18 16:52

Description

Trying to create an ExceptionMapper for the validation exceptions I notice that there are 2 kind of exceptions that are thrown when logging.

AbstractEventLogger mostly throws AuditException, but there's even a IllegalStateException thrown, that probably can be changed to an AuditException.

But then there's LogEventFactory that throws ConstraintValidationException for validation errors.

I then thought there's an exception hierarchy in place, but it seems there's no relation between AuditException and ConstraintValidationException.

Please consider making AbstractEventLogger also throw ConstraintValidationException and maybe create some hierarchy for these exceptions to provide them a common base exception, perhaps AuditException.

Issue Links

• is blocked by: LOG4J2-2421 AbstractEventLogger.logEvent doesn't check for missing required context attributes
• links to: GitHub Pull Request #4