[LANG-929] OctalUnescaper code is complex, leading to bugs

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2
• Component/s: lang.text.translate.*
• Assignee: Henri Yandell
• Reporter: Henri Yandell
• Created: 26/Oct/13 02:19
• Updated: 02/Jan/14 16:19
• Resolved: 26/Oct/13 02:45

Description

My gut is that the code in OctalUnescaper is unnecessarily complex. It feels simpler to look at the legitimate values for an Octal more explicitly.

Thinking the current code through, it fails if you pass it \279. That should be octal \27 followed by a 9, but instead it will try to parse it as an Octal and throw a NumberFormatException.