[LANG-567] ArrayUtils.addAll(T[] array1, T... array2) does not handle mixed types very well

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5
• Component/s: lang.*
• Assignee: Unassigned
• Reporter: Sebb
• Created: 16/Dec/09 15:05
• Updated: 25/Feb/10 19:38
• Resolved: 18/Dec/09 02:53

Description

ArrayUtils.addAll(T[] array1, T... array2) does not handle mixed array types very well.

The stack trace for

Number[] st = ArrayUtils.addAll(new Integer[]

{1}

, new Long[]

{2L}

);

starts:

java.lang.ArrayStoreException
at java.lang.System.arraycopy(Native Method)
at org.apache.commons.lang3.ArrayUtils.addAll(ArrayUtils.java:2962)

which is not all that obvious.

It would be a lot clearer if the method threw an IlegalArgumentException or similar.