[#LANG-468] JDK 1.5 build/runtime failure on LANG-393 (EqualsBuilder)

Commons Lang

JDK 1.5 build/runtime failure on LANG-393 (EqualsBuilder)

Created: 05/Nov/08 03:58 PM Updated: 06/Nov/08 08:36 PM

Return to search

Component/s:

None

Affects Version/s:

2.4

Fix Version/s:

3.0

Time Tracking:

Not Specified

Issue Links:

Duplicate

This issue duplicates:

~~LANG-464~~ EqualsBuilder doesn't compile in 2.4 source code release

Reference

This issue relates to:

~~LANG-393~~ EqualsBuilder don't compare BigDecimals correctly

Resolution Date:

06/Nov/08 08:36 PM

Description

« Hide

See ~~LANG-393~~

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Henri Yandell made changes - 05/Nov/08 03:58 PM

Field	Original Value	New Value
Link		This issue relates to ~~LANG-393~~ [ ~~LANG-393~~ ]

Henri Yandell made changes - 06/Nov/08 08:29 PM

Link

This issue duplicates ~~LANG-464~~ [ ~~LANG-464~~ ]

[ Permlink | « Hide ]

Henri Yandell added a comment - 06/Nov/08 08:30 PM

(From ~~LANG-464~~)

Line 381 of org.apache.commons.lang.EqualsBuilder fails to compile because the compareTo call requires a BigDecimal rather than an object.

376 public EqualsBuilder append(Object lhs, Object rhs) {
...
379 if (!lhsClass.isArray()) {
380 if (lhs instanceof java.math.BigDecimal) { 381 isEquals = (((java.math.BigDecimal)lhs).compareTo(rhs) == 0); 382 } else {

I'm using Sun's JDK 1.6.0_07 in Eclipse, not sure if this is a JDK version issue or not.

Repository	Revision	Date	User	Message
ASF	#711969	Thu Nov 06 20:36:17 UTC 2008	bayard	Updating the BigDecimal.compareTo(Object) to BigDecimal.compareTo(BigDecimal) to match JDK change - fixes ~~LANG-468~~/~~LANG-464~~
				Files Changed
				MODIFY /commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/EqualsBuilder.java

[ Permlink | « Hide ]

Henri Yandell added a comment - 06/Nov/08 08:36 PM

svn ci -m "Updating the BigDecimal.compareTo(Object) to BigDecimal.compareTo(BigDecimal) to match JDK change - fixes ~~LANG-468~~/~~LANG-464~~" src

Sending src/java/org/apache/commons/lang/builder/EqualsBuilder.java
Transmitting file data .
Committed revision 711969.

Henri Yandell made changes - 06/Nov/08 08:36 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]