Issue Details (XML | Word | Printable)

Key: LANG-393
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: Luis Henriques
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Commons Lang

EqualsBuilder don't compare BigDecimals correctly

Created: 03/Jan/08 01:46 PM   Updated: 14/Nov/09 10:11 AM
Return to search
Component/s: None
Affects Version/s: 2.3
Fix Version/s: 2.4

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works LANG-393.patch 2008-01-11 06:15 AM Henri Yandell 2 kB
Issue Links:
Reference
 

Resolution Date: 13/Jan/08 07:00 AM


 Description  « Hide
When comparing a BigDecimal, the comparing is made using equals, not compareTo, which is more appropriate in the case of BigDecimal.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #611543 Sun Jan 13 07:00:22 UTC 2008 bayard Applying my patch from LANG-393; EqualsBuilder uses compareTo for BigDecimal and not equals
Files Changed
MODIFY /commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java
MODIFY /commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/EqualsBuilder.java

Repository Revision Date User Message
ASF #836149 Sat Nov 14 10:10:19 UTC 2009 bayard Rolling back r611543 for LANG-393, and removing the special handling of BigDecimal to use compareTo instead of equals because it creates an inequality with HashCodeBuilder [reported in LANG-467 by David Jones]
Files Changed
MODIFY /commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java
MODIFY /commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/EqualsBuilder.java