[#LANG-369] ExceptionUtils not thread-safe

Commons Lang

ExceptionUtils not thread-safe

Created: 30/Oct/07 05:36 PM Updated: 16/May/09 07:32 AM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

3.0, 2.x

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
LANG-369-2.patch	2009-03-14 02:39 PM	Sebb	3 kB
LANG-369.patch	2007-11-09 08:20 AM	Henri Yandell	4 kB

Resolution Date:

17/Mar/09 08:55 PM

Description

« Hide

The ExceptionUtils class does not appear to be thread-safe:

CAUSE_METHOD_NAMES is not final, so may not be visible to all threads
addCauseMethodName() and removeCauseMethodName() can update CAUSE_METHOD_NAMES but are not synch.
all accesses to CAUSE_METHOD_NAMES probably need to be synchronised

The documentation does not state whether or not the class is thread-safe, but given that it only has static methods it does not make any sense unless it is thread-safe.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#594278	Mon Nov 12 19:58:30 UTC 2007	bayard	Applying the synchronization from ~~LANG-369~~
				Files Changed
				MODIFY /commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/ExceptionUtils.java

Repository	Revision	Date	User	Message
ASF	#755391	Tue Mar 17 20:54:52 UTC 2009	sebb	~~LANG-369~~ - must use fixed object as lock target
				Files Changed
				MODIFY /commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/ExceptionUtils.java