[#LANG-367] FastDateFormat thread safety

Commons Lang

FastDateFormat thread safety

Created: 30/Oct/07 01:25 PM Updated: 24/Apr/08 01:35 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

2.4

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	FastDateFormat.patch	2007-10-30 01:25 PM	Sebb	1 kB

Issue Links:

Duplicate

This issue is duplicated by:

~~LANG-429~~ NullPointerException (NPE) in FastDateFormat.getInstance(FastDateFormat.java:211)

Resolution Date:

05/Nov/07 09:55 AM

Description

« Hide

FastDateFormat has several static HashMaps. These are currently not final, so there is no guarantee that they will be visible to all threads.

Patch to follow.

Also, as far as I can make out, the class shares SimpleDateFormat instances between threads.

It does not document why this is OK.

I'm guessing that it assumes that instances of the SimpleDateFormat class are thread-safe provided that they have the same attributes, but this is not documented. If this is the case, it's not clear that it is a valid assumption.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

No work has yet been logged on this issue.