[LANG-1123] Unit test FastDatePrinterTimeZonesTest needs a timezone set

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5
• Component/s: lang.time.*

Environment

Java 6, timezone is "Europe/Paris" (GMT/UTC +01:00), GNU/Linux.

• Flags: Important
• Assignee: Charles Honton
• Reporter: Christian P. MOMON
• Created: 30/Apr/15 02:38
• Updated: 19/Oct/16 07:01
• Resolved: 01/May/15 02:24

Description

In file :

src/test/java/org/apache/commons/lang3/time/FastDatePrinterTimeZonesTest.java

The unit test testCalendarTimezoneRespected set a timezone for the expectedValue but none for the actualValue. Because the actualValue use always the default timezone, then It has to fail.

Actually, there is no fail because of a bug in FastDatePrinter.format() method (see LANG-916).

When applying the LANG-916 patch, the unit test flood more than 600 failed:

cpm > mvn test
Failed tests:
[...]
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[2:19PM EDT]> but was:<[6:19PM UTC]>
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[2:19PM AST]> but was:<[6:19PM UTC]>
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[12:19PM MDT]> but was:<[6:19PM UTC]>
  FastDatePrinterTimeZonesTest.testCalendarTimezoneRespected:61 expected:<[1:19PM ACT]> but was:<[6:19PM UTC]>
[...]
Tests run: 3544, Failures: 617, Errors: 0, Skipped: 5

Issue Links

• is related to: LANG-1127 Use JUnit rules to set and reset the default Locale and TimeZone
• is required by: LANG-916 CLONE - DateFormatUtils.format does not correctly change Calendar TimeZone in certain situations