[LANG-1091] Shutdown thread pools in test cases

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.2
• Fix Version/s: 3.4
• Component/s: lang.builder.*, lang.concurrent.*

Environment

Linux, JDK 7

• Assignee: Benedikt Ritter
• Reporter: Jesper Öqvist
• Created: 10/Mar/15 13:58
• Updated: 06/Apr/15 17:28
• Resolved: 26/Mar/15 10:21

Description

The tests, in for example org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest, create thread pools which are not shut down properly, leading to idle worker threads that can prevent the JVM from shutting down properly.

Suggested fix: shutdown() on the thread pool where a call to shutdown or shutdownNow is missing.

Affected classes (these were the ones I could find easily, I may have missed some):

• org.apache.commons.lang3.builder.ReflectionToStringStyleConcurrencyTest
• org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest
• org.apache.commons.lang3.concurrent.CallableBackgroundInitializerTest