Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-1090

FastDateParser does not set error indication in ParsePosition

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.4
    • None
    • None

    Description

      FastDateParser#parse(String,ParsePosition) does not throw ParseException if the input cannot be matched.

      If the parse succeeds, the ParsePosition is updated to the index of the next character after the last one used, and the error index is left as -1.

      If the parse fails, at present the ParsePosition is not updated at all, unlike SimpleDateFormat which is able to set the error Index to the location where the error occurr.

      It does not appear to be possible to determine the error location because the matching against the format string is all or nothing.

      This means that a successful parse can only be detected by checking whether the ParsePosition has been updated.

      This needs to be documented, and some unit tests added.

      Attachments

        Activity

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: