[LANG-1055] StrSubstitutor.replaceSystemProperties does not work consistently

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.2
• Fix Version/s: 3.4
• Component/s: lang.text.*

Environment

Windows 7, Java 7

• Assignee: Benedikt Ritter
• Reporter: Phil Dicke
• Created: 22/Oct/14 12:59
• Updated: 06/Apr/15 17:28
• Resolved: 23/Jan/15 08:11

Description

StrSubsitutor caches a references to SystemProperties statically on first class references. This does not work properly with System.setProperties(). For example the following code:

package test.utilities;

import java.util.Properties;

import org.apache.commons.lang.text.StrSubstitutor;

public class TestStrSubstitutor {

    public static void main(String[] args) {
        System.out.println(StrSubstitutor.replaceSystemProperties("os.name=${os.name}"));
        Properties testProps = new Properties();
        testProps.put("test_key",  "test_value");
        testProps.putAll(System.getProperties());
        System.setProperties(testProps);
        System.out.println(StrSubstitutor.replace("test_key=${test_key}", System.getProperties()));
        System.out.println(StrSubstitutor.replaceSystemProperties("test_key=${test_key}"));
    }

}

produces the following output:

os.name=Windows 7
test_key=test_value
test_key=${test_key}

The code linked here shows the static caching of the System Properties reference: http://commons.apache.org/proper/commons-lang/apidocs/src-html/org/apache/commons/lang3/text/StrLookup.html