[KAFKA-7477] Improve Streams close timeout semantics

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.1.0
• Component/s: streams
• Labels: kip newbie
• Assignee: Nikolay Izhikov
• Reporter: John Roesler
• Created: 03/Oct/18 20:17
• Updated: 09/Oct/18 18:38
• Resolved: 09/Oct/18 18:38

Description

See https://github.com/apache/kafka/pull/5682#discussion_r221473451

The current timeout semantics are a little "magical":

• 0 means to block forever
• negative numbers cause the close to complete immediately without checking the state

I think this would make more sense:

• reject negative numbers
• make 0 just signal and return immediately (after checking the state once)
• if I want to wait "forever", I can use ofYears(1) or ofMillis(Long.MAX_VALUE) or some other intuitively "long enough to be forever" value instead of a magic value.

 

Part of https://cwiki.apache.org/confluence/display/KAFKA/KIP-358%3A+Migrate+Streams+API+to+Duration+instead+of+long+ms+times

Issue Links

• is a child of: KAFKA-7277 Migrate Streams API to Duration instead of longMs times
• links to: GitHub Pull Request #5747
• mentioned in: Page Loading...
• mentioned in: Page Loading...