[KAFKA-6412] Improve synchronization in CachingKeyValueStore methods

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: streams
• Assignee: Zhihong Yu
• Reporter: Ted Yu
• Created: 30/Dec/17 08:18
• Updated: 10/Jan/18 19:38
• Resolved: 10/Jan/18 10:24

Description

Currently CachingKeyValueStore methods are synchronized at method level.

It seems we can use read lock for getter and write lock for put / delete methods.

For getInternal(), if the underlying thread is streamThread, the getInternal() may trigger eviction. This can be handled by obtaining write lock at the beginning of the method for streamThread.

Issue Links

• links to: GitHub Pull Request #4372