[KAFKA-6363] Use MockAdminClient for any unit tests that depend on AdminClient

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: newbie
• Assignee: Filipe Agapito
• Reporter: Guozhang Wang
• Created: 14/Dec/17 18:27
• Updated: 09/Jan/18 03:20
• Resolved: 09/Jan/18 03:20

Description

Today we have a few unit tests other than KafkaAdminClientTest that relies on MockKafkaAdminClientEnv.

About this class and MockKafkaAdminClientEnv, my thoughts:

1. MockKafkaAdminClientEnv is actually using a MockClient for the inner KafkaClient; it should be only used for the unit test of KafkaAdminClient itself.

2. For any other unit tests on classes that depend on AdminClient, we should be using the MockAdminClient that mocks the whole AdminClient.

So I suggest 1) in TopicAdminTest use MockAdminClient instead; 2) in KafkaAdminClientTest use MockClient and added a new static constructor that takes a KafkaClient; 3) remove the MockKafkaAdminClientEnv.

Issue Links

• links to: GitHub Pull Request #4371