[KAFKA-6029] Controller should wait for the leader migration to finish before ack a ControlledShutdownRequest

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 2.2.0
• Component/s: controller, core
• Assignee: Zhanxiang (Patrick) Huang
• Reporter: Jiangjie Qin
• Created: 09/Oct/17 18:58
• Updated: 29/May/19 02:15
• Resolved: 29/May/19 02:14

Description

In the controlled shutdown process, the controller will return the ControlledShutdownResponse immediately after the state machine is updated. Because the LeaderAndIsrRequests and UpdateMetadataRequests may not have been successfully processed by the brokers, the leader migration and active ISR shrink may not have done when the shutting down broker proceeds to shut down. This will cause some of the leaders to take up to replica.lag.time.max.ms to kick the broker out of ISR. Meanwhile the produce purgatory size will grow.

Ideally, the controller should wait until all the LeaderAndIsrRequests and UpdateMetadataRequests has been acked before sending back the ControlledShutdownResponse.

Issue Links

• is related to: KAFKA-5027 Kafka Controller Redesign