[KAFKA-5548] SchemaBuilder does not validate input.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: connect
• Assignee: Jeremy Custenborder
• Reporter: Jeremy Custenborder
• Created: 30/Jun/17 21:09
• Updated: 01/Jul/17 09:48
• Resolved: 01/Jul/17 09:47

Description

SchemaBuilder.map(), SchemaBuilder.array(), and SchemaBuilder.field() do not validate input. This can cause weird NullPointerException exceptions later. For example I mistakenly called field("somefield", null), then later performed an operation against field.schema() which yielded a null. It would be preferable to throw an exception stating the issue. We could throw the a NPE but state what is null. Schema is null in this case for example.

  @Test(expected = NullPointerException.class)
  public void fieldNameNull() {
    Schema schema = SchemaBuilder.struct()
        .field(null, Schema.STRING_SCHEMA)
        .build();
  }

  @Test(expected = NullPointerException.class)
  public void fieldSchemaNull() {
    Schema schema = SchemaBuilder.struct()
        .field("fieldName", null)
        .build();
  }

  @Test(expected = NullPointerException.class)
  public void arraySchemaNull() {
    Schema schema = SchemaBuilder.array(Schema.STRING_SCHEMA)
        .build();
  }

  @Test(expected = NullPointerException.class)
  public void mapKeySchemaNull() {
    Schema schema = SchemaBuilder.map(null, Schema.STRING_SCHEMA)
        .build();
  }

  @Test(expected = NullPointerException.class)
  public void mapValueSchemaNull() {
    Schema schema = SchemaBuilder.map(Schema.STRING_SCHEMA, null)
        .build();
  }

Issue Links

• links to: GitHub Pull Request #3474