[KAFKA-4855] Struct SchemaBuilder should not allow duplicate fields.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.2.0
• Fix Version/s: 0.11.0.0
• Component/s: connect
• Labels: newbie
• Assignee: Balint Molnar
• Reporter: Jeremy Custenborder
• Created: 06/Mar/17 22:14
• Updated: 04/Apr/17 03:10
• Resolved: 04/Apr/17 03:10

Description

I would expect this to fail at the build() on schema. It actually makes it all the way to Struct.validate() and throws a cryptic error message. .field() should throw an exception if a field is already used.

Repro:

  @Test
  public void duplicateFields() {
    final Schema schema = SchemaBuilder.struct()
        .name("testing")
        .field("id", SchemaBuilder.string().doc("").build())
        .field("id", SchemaBuilder.string().doc("").build())
        .build();
    final Struct struct = new Struct(schema)
        .put("id", "testing");
    struct.validate();
  }

org.apache.kafka.connect.errors.DataException: Invalid value: null used for required field at org.apache.kafka.connect.data.ConnectSchema.validateValue(ConnectSchema.java:212)
	at org.apache.kafka.connect.data.Struct.validate(Struct.java:232)
	at io.confluent.kafka.connect.jms.RecordConverterTest.duplicateFieldRepro(RecordConverterTest.java:289)

Issue Links

• links to: GitHub Pull Request #2732