[KAFKA-4734] timeindex on old segments not trimmed to actual size - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 0.10.1.0
Fix Version/s: 0.10.2.0
Component/s: None
Labels:
None

Description

When upgrading from 0.9.0 to 0.10.1, the broker creates empty .timeindex files on old log segments without trimming them. So, on disk, you will see .timeindex files with preallocated size.

~~rw-r~~r- 1 junrao wheel 10485756 Feb 3 15:15 00000000000000000000.timeindex
~~rw-r~~r- 1 junrao wheel 10485756 Feb 3 15:15 00000000000000000960.timeindex
~~rw-r~~r- 1 junrao wheel 10485756 Feb 3 15:15 00000000000000001920.timeindex
~~rw-r~~r- 1 junrao wheel 10485756 Feb 3 15:15 00000000000000002880.timeindex
~~rw-r~~r- 1 junrao wheel 10485756 Feb 3 15:15 00000000000000003840.timeindex
~~rw-r~~r- 1 junrao wheel 10485760 Feb 3 15:15 00000000000000004800.index
~~rw-r~~r- 1 junrao wheel 10485756 Feb 3 15:15 00000000000000004800.timeindex

If the broker is restarted again, all .timeindex files (except for the one on the active segment) are trimmed to 0 size. It would be better if we do that in the first place.