Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-4326

Refactor LogCleaner to remove duplicate log copying logic

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.10.2.0
    • None
    • None

    Description

      I think there's some code duplication in the log cleaner with respect to the copying of the log and re-compression after cleaning. We have similar logic already in ByteBufferMessageSet which we can potentially reuse. This improves encapsulation so that message format changes in the future become a little easier (since they touch fewer components).

      Attachments

        Issue Links

          Activity

            People

              hachikuji Jason Gustafson
              hachikuji Jason Gustafson
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: