[KAFKA-3940] Log should check the return value of dir.mkdirs()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0.0
• Fix Version/s: 0.11.0.0
• Component/s: log
• Labels: newbie reliability
• Assignee: Colin McCabe
• Reporter: Jun Rao
• Created: 08/Jul/16 19:47
• Updated: 11/Dec/17 16:03
• Resolved: 24/Apr/17 16:53

Description

In Log.loadSegments(), we call dir.mkdirs() w/o checking the return value and just assume the directory will exist after the call. However, if the directory can't be created (e.g. due to no space), we will hit NullPointerException in the next statement, which will be confusing.

for(file <- dir.listFiles if file.isFile) {

Issue Links

• is related to: KAFKA-4899 Fix findbugs warnings in kafka-core
• links to: GitHub Pull Request #1787
• links to: GitHub Pull Request #2944