[KAFKA-1927] Replace requests in kafka.api with requests in org.apache.kafka.common.requests

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: Gwen Shapira
• Reporter: Jay Kreps
• Created: 08/Feb/15 00:53
• Updated: 03/Jan/19 01:36
• Resolved: 03/Jan/19 01:36

Description

The common package introduced a better way of defining requests using a new protocol definition DSL and also includes wrapper objects for these.

We should switch KafkaApis over to use these request definitions and consider the scala classes deprecated (we probably need to retain some of them for a while for the scala clients).

This will be a big improvement because
1. We will have each request now defined in only one place (Protocol.java)
2. We will have built-in support for multi-version requests
3. We will have much better error messages (no more cryptic underflow errors)

Issue Links

• blocks: KAFKA-1694 KIP-4: Command line and centralized operations
• is blocked by: KAFKA-1634 Improve semantics of timestamp in OffsetCommitRequests and update documentation
• is depended upon by: KAFKA-1931 Refactor server to use code in org.apache.kafka.common
• is duplicated by: KAFKA-2006 switch the broker server over to the new java protocol definitions
• is duplicated by: KAFKA-1486 Move all request/responses to use schema-utils
• is related to: KAFKA-2929 Migrate server side error mapping functionality

Sub-Tasks

• Add ControlledShutdown to org.apache.kafka.common.requests: Resolved
• Add LeaderAndISR request/response to org.apache.kafka.common.requests: Resolved
• Add UpdateMetadata request/response to o.a.k.common.requests: Resolved
• Add versionId to AbstractRequest.getErrorResponse and AbstractRequest.getRequest: Resolved
• Replace ConsumerMetadataRequest and Response with org.apache.kafka.common.requests objects: Resolved
• Replace OffsetRequest/response with ListOffsetRequest/response from org.apache.kafka.common.requests: Resolved
• Replace LeaderAndIsr{Request,Response} with org.apache.kafka.common.network.requests equivalent: Resolved
• Add StopReplica request/response to o.a.k.common.requests and replace the usage in core module: Resolved
• Replace Produce Request/Response with their org.apache.kafka.common.requests equivalents: Resolved
• Replace UpdateMetadata{Request,Response} with org.apache.kafka.common.requests equivalent: Resolved
• Replace OffsetFetch request/response with their org.apache.kafka.common.requests equivalent: Resolved
• Replace OffsetCommit Request/Response with org.apache.kafka.common.requests equivalent: Resolved
• Replace TopicMetadata request/response with o.a.k.requests.metadata: Resolved
• Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents: Resolved
• Replace ControlledShutdown{Request,Response} with org.apache.kafka.common.requests equivalent: Resolved
• Remove temporary mapping to deserialize functions in RequestChannel: Resolved
• Refactor MetadataCache to be optimal for o.a.k.c requests: Resolved
• Refactor ReplicaManager to be optimal for o.a.k.c requests: Resolved
• Refactor KafkaApis to be optimal for o.a.k.c requests: Open
• Replace server internal usage of TopicAndPartition with TopicPartition: Resolved
• Mark the old Scala producer and related classes as deprecated: Resolved
• Mark the old Scala consumer and related classes as deprecated: Resolved
• Validate that all kafka.api requests has been removed and clean up compatibility code: Resolved