[KAFKA-1841] OffsetCommitRequest API - timestamp field is not versioned

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.8.2.0
• Fix Version/s: 0.8.2.0
• Component/s: core
• Environment: wire-protocol
• Assignee: Jun Rao
• Reporter: Dana Powers
• Created: 05/Jan/15 20:17
• Updated: 18/Mar/15 16:16
• Resolved: 13/Jan/15 06:34

Description

Timestamp field was added to the OffsetCommitRequest wire protocol api for 0.8.2 by KAFKA-1012 . The 0.8.1.1 server does not support the timestamp field, so I think the api version of OffsetCommitRequest should be incremented and checked by the 0.8.2 kafka server before attempting to read a timestamp from the network buffer in OffsetCommitRequest.readFrom (core/src/main/scala/kafka/api/OffsetCommitRequest.scala)

It looks like a subsequent patch (KAFKA-1462) added another api change to support a new constructor w/ params generationId and consumerId, calling that version 1, and a pending patch (KAFKA-1634) adds retentionMs as another field, while possibly removing timestamp altogether, calling this version 2. So the fix here is not straightforward enough for me to submit a patch.

This could possibly be merged into KAFKA-1634, but opening as a separate Issue because I believe the lack of versioning in the current trunk should block 0.8.2 release.

Issue Links

• Is contained by: KAFKA-1634 Improve semantics of timestamp in OffsetCommitRequests and update documentation