Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1805

Kafka ProducerRecord should implement equals

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.8.2.0
    • None
    • producer
    • None

    Description

      I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality.

      This makes tests integrating kafka particularly awkward.

      https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java

      I can whip up a patch since this is essentially just a value object.

      Thanks,
      Thomas Omans

      Attachments

        1. KAFKA-1805.patch
          38 kB
          Parth Brahmbhatt
        2. KAFKA-1805_2014-12-29_16:37:11.patch
          2 kB
          Parth Brahmbhatt
        3. KAFKA-1805_2015-02-11_14:30:14.patch
          5 kB
          Parth Brahmbhatt
        4. KAFKA-1805_2015-02-11_14:34:28.patch
          6 kB
          Parth Brahmbhatt
        5. KAFKA-1805_2015-02-11_14:37:09.patch
          6 kB
          Parth Brahmbhatt
        6. KAFKA-1805_2015-02-11_14:37:41.patch
          6 kB
          Parth Brahmbhatt
        7. KAFKA-1805_2015-02-11_14:49:10.patch
          9 kB
          Parth Brahmbhatt

        Activity

          People

            parth.brahmbhatt Parth Brahmbhatt
            eggsby Thomas Omans
            Guozhang Wang Guozhang Wang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: