Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1560

Make arguments to jira-python API more explicit in kafka-patch-review's get_jira()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      I ran into an issue with kafka-patch-review.py as a result of a change in parameters for the JIRA() object between jira-python 0.28 and 0.29. A quick fix is to make parameters more explicit.

      As a side note, there is a separate bug affecting the review tool, but I'm not sure it's fixable without modifying the jira-python source (https://bitbucket.org/bspeakmon/jira-python/issue/122/clientissue-function-needs-param-removal)

      It seems the answer is that people should not use jira-python 0.29 yet, since it's a little broken.

      Attachments

        1. KAFKA-1560.patch
          0.8 kB
          Neha Narkhede
        2. KAFKA-1560.patch
          0.5 kB
          Jonathan Natkins

        Activity

          People

            natty Jonathan Natkins
            natty Jonathan Natkins
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: