setRenderParameter affects action params

• Key: JS2-194
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Ate Douma
• Reporter: Johnny Rodriguez
• Component/s: Container
• Affects Version/s: 2.0-M2
• Fix Version/s: 2.0-M3

Environment

Windows XP SP2
java version "1.4.2_06"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_06-b03)
Java HotSpot(TM) Client VM (build 1.4.2_06-b03, mixed mode)
Tomcat 4.1.29

Description

Calling:
javax.portlet.ActionResponse.setRenderParameter(String, String) or
javax.portlet.ActionResponse.setRenderParameter(String, String [])

during a call to:
javax.portlet.Portlet.processAction(ActionRequest, ActionResponse)

causes the specified render parameters to be returned by:
javax.portlet.ActionRequest.getParameter(String),
javax.portlet.ActionRequest.getParameterMap(),
javax.portlet.ActionRequest.getParameterNames() and
javax.portlet.ActionRequest.getParameterValues(String)

during the next call to:
javax.portlet.Portlet.processAction(ActionRequest, ActionResponse)

THIS IS INCORRECT.

The specified render parameters should only be available when calling:
javax.portlet.RenderRequest.getParameter(String),
javax.portlet.RenderRequest.getParameterMap(),
javax.portlet.RenderRequest.getParameterNames() and
javax.portlet.RenderRequest.getParameterValues(String)

during a subsequent call to:
javax.portlet.Portlet.render(RenderRequest, RenderResponse)

and should disappear just before the next call to:
javax.portlet.Portlet.processAction(ActionRequest, ActionResponse)

so that they are not available to subsequent calls to:
javax.portlet.Portlet.render(RenderRequest, RenderResponse)

unless explicitly set again.

Comments

[Ate Douma]

I will look into this starting next week.

[garpinc]

I think I am experiencing same. Is this a duplicate of http://issues.apache.org/jira/browse/JS2-231 or is this a separate issue?

[Ate Douma]

Started work on JS2-194. Solving it will solve this too.

Fixed. Please test.

[garpinc]

If there was a nightly build I could test but I could find none. Is the change only in that java class

[Ate Douma]

There are no nightly builds for Jetspeed.
To be able to test out the changes, you have to checkout a fresh version of Jetspeed-2 from cvs (or update if you already have done so before).

[garpinc]

~ when will jetspeed2 M3 be released. I'll test it then. I don't have the time to set up a build env.

[Ate Douma]

Hopefully M3 will be released in a few weeks time.
Too bad you cannot test it though. If you find problems after M3 is release, you'll have to wait
for another release again to get a fix in.

[garpinc]

If you post it somewhere where I can download it then I can test it. The version I have is called jetspeed-2.0-M2-Tomcat-5.5.8.zip. Alternatively you can tell me all the classes affected by this change and I can override them in my class path.