Issue Details (XML | Word | Printable)

Key: JS2-191
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: David Sean Taylor
Reporter: Christophe Lombart
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Jetspeed 2

Rss Application - Use the Rome Framework

Created: 14/Jan/05 08:12 AM   Updated: 19/Jan/05 02:44 AM
Return to search
Component/s: Demo Portlets
Affects Version/s: 2.0-M1
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works patch-rss.txt 2005-01-15 07:27 AM Christophe Lombart 24 kB
Text File Licensed for inclusion in ASF works patch-rss.txt 2005-01-14 08:15 AM Christophe Lombart 109 kB

Resolution Date: 19/Jan/05 02:44 AM


 Description  « Hide
In order be to more generic, The RSS application can used the Rome framework. By this way, XSL is not necessary.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Christophe Lombart added a comment - 14/Jan/05 08:15 AM
Here is the patch. Let me know if something is wrong. This patch doesn't contains some caching features.

Christophe Lombart made changes - 14/Jan/05 08:15 AM
Field Original Value New Value
Attachment patch-rss.txt [ 18638 ]
David Sean Taylor added a comment - 14/Jan/05 03:08 PM
I can't accept this patch.

You deleted the RSS XSLT portlet, and all the transformation cache code that worked very hard on.
My goal was to have two RSS portlets:

1. XSLT based
2. Rome based

Why did you remove the XSLT version and transform cache?

If you want to leave the XSLT (RSS) portlet as is, and put back the cache, then I'll be glad to check it in as the Rome implementation looks great.

Thanks

David Sean Taylor made changes - 14/Jan/05 03:13 PM
Assignee David Sean Taylor [ taylor ]
David Sean Taylor made changes - 14/Jan/05 03:13 PM
Status Open [ 1 ] In Progress [ 3 ]
Christophe Lombart added a comment - 14/Jan/05 06:31 PM
No problem. I will send you a new patch this evening.

Why do you want to have both implementation to have the same result ? As you suggested, Rome+Velocity is so simple.




David Sean Taylor added a comment - 15/Jan/05 03:05 AM
"Why do you want to have both implementation to have the same result ? As you suggested, Rome+Velocity is so simple."

Because its an open source project an lots of people work with XSLT, no matter how much I dislike it :-)

There are lots of existing transforms for RSS that can be easily integrated.

Christophe Lombart added a comment - 15/Jan/05 07:27 AM
Here is a new patch. Both portlets should be there.

Christophe Lombart made changes - 15/Jan/05 07:27 AM
Attachment patch-rss.txt [ 18651 ]
David Sean Taylor added a comment - 19/Jan/05 02:44 AM
patch applied and tested.

David Sean Taylor made changes - 19/Jan/05 02:44 AM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]