|
[
Permlink
| « Hide
]
Christophe Lombart added a comment - 14/Jan/05 08:15 AM
Here is the patch. Let me know if something is wrong. This patch doesn't contains some caching features.
Christophe Lombart made changes - 14/Jan/05 08:15 AM
I can't accept this patch.
You deleted the RSS XSLT portlet, and all the transformation cache code that worked very hard on. My goal was to have two RSS portlets: 1. XSLT based 2. Rome based Why did you remove the XSLT version and transform cache? If you want to leave the XSLT (RSS) portlet as is, and put back the cache, then I'll be glad to check it in as the Rome implementation looks great. Thanks
David Sean Taylor made changes - 14/Jan/05 03:13 PM
David Sean Taylor made changes - 14/Jan/05 03:13 PM
No problem. I will send you a new patch this evening.
Why do you want to have both implementation to have the same result ? As you suggested, Rome+Velocity is so simple. "Why do you want to have both implementation to have the same result ? As you suggested, Rome+Velocity is so simple."
Because its an open source project an lots of people work with XSLT, no matter how much I dislike it :-) There are lots of existing transforms for RSS that can be easily integrated. Here is a new patch. Both portlets should be there.
Christophe Lombart made changes - 15/Jan/05 07:27 AM
patch applied and tested.
David Sean Taylor made changes - 19/Jan/05 02:44 AM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||