[JEXL] Implement short-circuit boolean evaluation

• Key: JEXL-12
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Matthew Firth
• Fix Version/s: 1.0

Environment

Operating System: All
Platform: All

Description

The current implementation of ASTAndNode and ASTOrNode will evaluation both
sides of an expression before returning a result. I think most developers
these days seem to expect the RHS of an AND/OR expression to be ignored if the
LHS is sufficient to determine the result
(e.g. if A=>true, "A or B"=>true, regardless of B).

The patches appear to be trivial - if a committer is interested & thinks it
worthwhile I'll create them.

(btw, the old Turbo Pascal compiler described this optimisation as "short
circuit boolean evaluation"; I'm not sure if that is a common name for it.)

Comments

[dIon Gillard]

Sounds useful as well.

I'll take this one on.

[Matthew Firth]

Created an attachment (id=12457)
(tested) Patch to provide the enhancement I described.

[dIon Gillard]

Committed into CVS with tests

I did it a slightly longer-winded way, but there are tests too.