Issue Details (XML | Word | Printable)

Key: JELLY-47
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: dion gillard
Reporter: Ben Walding
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Commons Jelly

Attribute corruption when dealing with converting attributes that include namespaces

Created: 12/Apr/03 02:40 PM   Updated: 02/Sep/04 06:13 AM
Return to search
Component/s: core / taglib.core
Affects Version/s: None
Fix Version/s: 1.0-beta-4

Time Tracking:
Not Specified

File Attachments:
  Size
Java Source File TestFileTag.java 2003-04-12 02:40 PM Ben Walding 5 kB
File testFileTag.jelly 2003-04-12 02:41 PM Ben Walding 0.2 kB

Resolution Date: 02/Sep/04 06:13 AM


 Description  « Hide
It seems like there is attribute corruption when dealing with converting attributes that include namespaces.

(It might be that my understanding on namespaces is a bit wrong, but I still think jelly is broken)

Essentially, the script

<j:jelly xmlns:j="jelly:core">
<j:file name="target/testFileTag.tmp" outputMode="html">
<html xmlns="http://www.w3.org/1999/xhtml"" xml:lang="en" lang="en">
</html>
</j:file>
</j:jelly>

is creating a file with the content (not even valid XML)

<html xmlns="http://www.w3.org/1999/xhtml lang="en"></html>

when I would expect it to produce something like

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"></html>

I have included tests cases and scripts for this scenario



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
dion gillard added a comment - 12/Aug/04 07:04 AM
The fixes have been committed into CVS.

dom4j 1.5-beta doesn't fix this issue.


dion gillard added a comment - 29/Aug/04 11:39 PM
FWIW, this is not a blocker for me for beta-4.

It seems that it is entirely a DOM4J issue.


Paul Libbrecht added a comment - 31/Aug/04 05:41 AM
I can't reproduce the error anymore.
It was an issue of dom4j... would need to find the iD...

The following is working for me:
<?xml version="1.0" encoding="utf-8"?>
<j:jelly xmlns:j="jelly:core">
   <j:file name="testFileTag.tmp" outputMode="html">
     <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
     </html>
   </j:file>
</j:jelly>

paul


dion gillard added a comment - 31/Aug/04 06:38 AM
The test is commented out in TestFileTag.java

dion gillard added a comment - 31/Aug/04 06:46 AM
Running with dom4j 1.5-rc1 and the testfiletag still fails.

dion gillard added a comment - 02/Sep/04 05:52 AM
I've found the issue here. The XmlParser class doesn't pass through qualified attribute names to TagScripts.

I'm going to special case xml:* attributes and pass them through qualified.


dion gillard added a comment - 02/Sep/04 06:13 AM
Fix for XMLParser applied.