resource lookup in compiled scripts does not work properly

• Key: JELLY-45
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: dion gillard
• Reporter: Vincenz Braun
• Component/s: core / taglib.core
• Fix Version/s: 1.0-beta-5

Description

Take the following code snippet:

JellyContext context = new JellyContext();
URL url = ImportTestcase.class.getResource("/resources/import.jelly");
XMLOutput out = XMLOutput.createXMLOutput(System.out);
// this works because of the created child context that has knowledge
// of the URL
context.runScript(url, out);

// This does not work because context has no currentURL set
// This results in a NullPointerException when resolving the
// stylesheet
Script script = context.compileScript(url);
script.run(context, out);
out.flush()

A compiled script should manage the lookup of referenced
resources by its own regardless of the context set. If you
cache scripts and use different contexts you do not always know
where the script is from.
That's why context.setCurrentURL(...) is no solution.

// import.jelly
<?xml version="1.0" encoding="ISO-8859-1"?>
<j:jelly xmlns:j="jelly:core" xmlns:x="jelly:xml" >
<x:transform xslt="import.xsl">
<x:param name="language" value="DE"/>
<root/>
</x:transform>
</j:jelly>

Comments

[peter royal]

If you could create a failing testcase for this, that would be superb!

[dion gillard]

Failing test case is in the xml taglib, as TestImport.java

[dion gillard]

This is not just limited to compiled scripts either. I will commit a test for uncompiled scripts that fails too.

[dion gillard]

Vincenz, are you interested in reviewing my solution?

[dion gillard]

Updated TagScript and StaticTagScript to set the context urls when running a script.