FileTag must allow to append to flat file

• Key: JELLY-191
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Marc DeXeT
• Component/s: core / taglib.core
• Affects Version/s: 1.0-beta-4
• Fix Version/s: 1.0-RC2

Description

Core FileTag allows to write only XML or HTML content to file.
But there's a need to write flat content unix-like or in pseudo-xml (element collection without document root).
So FileTag must allow to write flat content to file.
Proposition to add a boolean "flat" property.

There also a need to add "append" property to.. append to existing file

Comments

[Paul Libbrecht]

A patch ?
(shouldn't be too hard)

I am unclear about the exact semantic of flat... I guess it's a summary of some other properties (e.g. no XML-header and ....).

paul

[dion gillard]

Huh? the file tag can write non-xml data. Just use the omitXmlDeclaration="true". What about that doesn't work?

[Paul Libbrecht]

Although that doesn't append, I think the following scripts shows the wished output so that blank-management is possible with the help of the trim attribute.
The only thing that'd be left would be to add an append flag to the Tag, seems quite easy.

paul

<?xml version="1.0" encoding="utf-8" ?>
<jelly xmlns="jelly:core" >
<new var="sections" className="java.util.LinkedList"/>
<new var="sec1" className="java.util.LinkedList"/>
<mute>${sec1.add('sleeping')}
${sec1.add('dreaming')}
${sec1.add('eating')}
${sections.add(sec1)}
<new var="sec2" className="java.util.LinkedList"/>
${sec2.add('working')}
${sec2.add('stressing')}
${sec2.add('firing')}
${sections.add(sec1)}</mute>

<forEach var="section" items="${sections}" trim="false">[GOALS_section]
<forEach var="idea" items="${section}">${idea}
</forEach>
</forEach>
</jelly>

[Paul Libbrecht]

I'd like to close this issue, it is working fine.
Use <file append="true" ....>.

paul

[dion gillard]

Paul has fixed this I believe.

AFAICT append is only checked when working with the name attribute set.

I propose fixing it for the case of 'var' as well.

[Paul Libbrecht]

Have added the append to be valid for var as well... sorry for this omission.
paul

[Paul Libbrecht]

Fixed in CVS.
paul