[#JELLY-113] TagSupport concurrency issue

Commons Jelly

TagSupport concurrency issue

Created: 01/Jul/04 02:47 PM Updated: 12/Aug/04 05:10 AM

Return to search

Component/s:

core / taglib.core

Affects Version/s:

None

Fix Version/s:

1.0-beta-4

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
TagSupport.java	2004-07-01 02:48 PM	Gary Franklin	11 kB
TagSupportPatch.txt	2004-07-01 02:48 PM	Gary Franklin	10 kB

Resolution Date:

12/Aug/04 05:10 AM

Description

« Hide

Assume you have a jelly tag <j:jelly> with children. The following sequence leads to concurrency problems:

1. Instance 1 of Tag is created on thread 1. Body is ScriptBlock
2. Instance 2 of Tag is created on thread 2. Body is same ScriptBlock as Instance 1.
3. doTag -> invokeBody -> getBody -> trimBody is called for Instance 1
4. same for instance 2
5. Instance 1 gets the size of the ScriptBlock
6. Instance 2 gets the size of the ScriptBlock
7. Instance 1 trims whitespace blocks
8. Instance 2 gets an IndexOutOfBounds exception since it resumes execution with an incorrect list size (list was changed by Instance 1).

Both threads concurrently trim the same ScriptBody (the hasTrimmed variable is instance-specific). The attached patch synchronizes access to the body within trimBody.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Gary Franklin made changes - 01/Jul/04 02:48 PM

Field	Original Value	New Value
Attachment		TagSupport.java [ 14695 ]

Gary Franklin made changes - 01/Jul/04 02:48 PM

Attachment

TagSupportPatch.txt [ 14696 ]

dion gillard made changes - 12/Aug/04 05:07 AM

Assignee

dion gillard [ diongillard ]

dion gillard made changes - 12/Aug/04 05:10 AM

Status	Open [ 1 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]
Fix Version/s		1.0-beta-4 [ 10215 ]