TestArrayCollections: Field "ArrayOfBigDecimal13" in class "ArrayCollections" has been defined with elements that arent embedded. JPOX doesnt support this

• Key: JDO-98
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Craig Russell
• Reporter: Michelle Caisse
• Component/s: tck2
• Fix Version/s: JDO 2 beta

Description

test(org.apache.jdo.tck.models.fieldtypes.TestArrayCollections)org.jpox.metadata.InvalidMetaDataException: Field "ArrayOfBigDecimal13" in class "ArrayCollections" has been defined with elements that arent embedded. JPOX doesnt support this - the elements must be embedded.
at org.jpox.metadata.ArrayMetaData.populate(ArrayMetaData.java:106)
at org.jpox.metadata.FieldMetaData.populate(FieldMetaData.java:662)
at org.jpox.metadata.ClassMetaData.populate(ClassMetaData.java:697)
at org.jpox.metadata.MetaDataManager.populateClassesInFile(MetaDataManager.java:635)
at org.jpox.metadata.MetaDataManager.getMetaDataForClassOrInterface(MetaDataManager.java:399)
at org.jpox.metadata.MetaDataManager.getMetaDataForClass(MetaDataManager.java:308)
at org.jpox.AbstractPersistenceManager.hasMetaDataForPersistenceCapableClass(AbstractPersistenceManager.java:381)
at org.jpox.AbstractPersistenceManager.assertPersistenceCapable(AbstractPersistenceManager.java:412)
at org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:950)
at org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1048)
at org.apache.jdo.tck.models.fieldtypes.TestArrayCollections.runTest(TestArrayCollections.java:95)
at org.apache.jdo.tck.models.fieldtypes.TestArrayCollections.test(TestArrayCollections.java:67)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:197)
at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:128)
at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:106)

Comments

[Michelle Caisse]

Mapping is messed up, needs to be redone.

[Michelle Caisse]

JPOX supports arrays but not arrays mapped to join tables. Currently JDO allows an imple mentation not to support arrays, but if it does support arrays they are expected to support mapping to join tables.

[Andy Jefferson]

Looking through the test further I see no use of <join> to imply a join table to be used to hold the objects in the array.
For example, field "ArrayOfBigDecimal12" is defined in the JDO file as
<field name="ArrayOfBigDecimal12" >
<array embedded-element="true">
</array>
</field>

and in the ORM as
<field name="ArrayOfBigDecimal12" column="ARRAY_OF_BIG_DECIMAL12"/>

So the user wants this treated as a non-serialized field and the array (BigDecimal) elements should be embedded. Where should they be embedded ? We have a column specified on the field. Shouldn't this be a table, and also have a join element ?

[Michelle Caisse]

I fixed the mapping for this class - revision 320862.
We get to the point where JPOX has not implemented support for arrays of some data types:
test(org.apache.jdo.tck.models.fieldtypes.TestArrayCollections)org.jpox.metadata.InvalidMetaDataException: Cannot persist field "ArrayOfDate8" of class "ArrayCollections" since it is of an array type that is not supported by JPOX. Please consider making this a Collection field.
at org.jpox.metadata.FieldMetaData.populate(FieldMetaData.java:825)
...

[Andy Jefferson]

JPOX CVS has support for much more in the array world now (like arrays of String, Date, etc, and persisting using a join table). Things like arrays of interfaces are supported partially. I suggest that you give it a try with the latest build

[Andy Jefferson]

With JPOX latest build this now fails with

test(org.apache.jdo.tck.models.fieldtypes.TestArrayCollections)javax.jdo.JDOUserException: Field "org.apache.jdo.tck.pc.fieldtypes.ArrayCollections.ArrayOfObject1" i
s declared as a reference type (interface/Object) but no implementation classes of "class java.lang.Object" have been found!
        at org.jpox.store.rdbms.table.ColumnCreator.getImplementationNamesForReferenceField(ColumnCreator.java:244)
        at org.jpox.store.rdbms.table.ColumnCreator.createColumnsForReferenceField(ColumnCreator.java:310)
        at org.jpox.store.rdbms.table.ColumnCreator.createColumnsForField(ColumnCreator.java:399)
        at org.jpox.store.rdbms.table.ColumnCreator.createColumns(ColumnCreator.java:94)

consequently the MetaData needs updates so that implementations can map it.

[Michelle Caisse]

What metadata can be used so implementation can map this?

[Craig Russell]

Issue 137 has been raised on the JDO expert group to allow specification of element-type for array. This will allow us to specify element-type of SimpleClass for Object[ ] and SimpleInterface[ ].

Independently, issue 138 has been raised to allow the implementation to specify whether they support references to Object and SimpleInterface to be mapped, or whether a more specific type is needed in the metadata.

[Craig Russell]

The final issue raised in this JIRA report has been resolved.

[Michael Bouschen]

Reopened to set the Fix Version/s field to JDO 2 beta.