Using datastore identity, JPOX expects an identity field for an embedded class (ADDRID for Address)

• Key: JDO-83
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Michelle Caisse
• Reporter: Michelle Caisse
• Component/s: tck2
• Fix Version/s: JDO 2 beta

Description

Affected tests (39):
org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability
org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithSubclasses
org.apache.jdo.tck.api.persistencemanager.lifecycle.MakePersistentAndInstancesNotReachable
org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerFactoryByPropertiesInstance
org.apache.jdo.tck.extents.CloseAll
org.apache.jdo.tck.extents.CloseOfExtentIteratorIsIteratorSpecific
org.apache.jdo.tck.extents.GetCandidateClass
org.apache.jdo.tck.extents.GetPersistenceManager
org.apache.jdo.tck.extents.HasSubclassesFalse
org.apache.jdo.tck.extents.HasSubclassesTrue
org.apache.jdo.tck.extents.InstancesDeletedPriorToIterationNotReturned
org.apache.jdo.tck.extents.InstancesPersistedPriorToIterationReturned
org.apache.jdo.tck.extents.IteratorHasNextFalseAfterExtentClose
org.apache.jdo.tck.extents.IteratorMutatingMethods
org.apache.jdo.tck.extents.IteratorNextAfterExtentCloseAll
org.apache.jdo.tck.extents.Iterators
org.apache.jdo.tck.mapping.CompletenessTest
org.apache.jdo.tck.models.embedded.SecondClassObjectsTrackTheirChanges
org.apache.jdo.tck.models.embedded.SecondClassObjectsTrackTheirChanges
org.apache.jdo.tck.query.Cast
org.apache.jdo.tck.query.ComparingCollectionFieldToNull
org.apache.jdo.tck.query.ComparingPersistentAndNonPersistentInstance
org.apache.jdo.tck.query.DenoteUniquenessInFilter
org.apache.jdo.tck.query.MultipleIdenticalImports
org.apache.jdo.tck.query.NavigationThroughACollectionField
org.apache.jdo.tck.query.NavigationThroughANullValuedField
org.apache.jdo.tck.query.NavigationThroughReferencesUsesDotOperator
org.apache.jdo.tck.query.NullCollectionsAndContainsMethod
org.apache.jdo.tck.query.NullCollectionsAndIsEmpty
org.apache.jdo.tck.query.ParameterBoundToDifferentPM
org.apache.jdo.tck.query.SeparateNamespaceForTypeNames
org.apache.jdo.tck.query.SetterReplacePreviousValues
org.apache.jdo.tck.query.StartsWithAndEndsWith
org.apache.jdo.tck.query.SupportedCollectionMethods
org.apache.jdo.tck.query.operators.EqualityAndComparisonsBetweenDateFieldsAndParameters
org.apache.jdo.tck.query.operators.EqualityAndComparisonsBetweenStringFieldsAndParameters
org.apache.jdo.tck.query.operators.StringConcatenation
org.apache.jdo.tck.transactions.SetNontransactionalRead
org.apache.jdo.tck.transactions.WhenNontransactionalReadIsFalse
 test(org.apache.jdo.tck.api.persistencemanager.lifecycle.MakePersistentAndInstancesNotReachable)javax.jdo.JDODataStoreException: Insert request failed: INSERT INTO datastoreidentity0.COMPANIES (FOUNDEDDATE,ADDRID,CITY,COUNTRY,"STATE",STREET,ZIPCODE,ID,"NAME") VALUES (?,?,?,?,?,?,?,?,?)
at org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:298)
at org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:1735)
at org.jpox.store.StoreManager.insert(StoreManager.java:663)
at org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3088)
at org.jpox.state.StateManagerImpl.makePersistent(StateManagerImpl.java:3061)
at org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:976)
at org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1012)
at org.apache.jdo.tck.api.persistencemanager.lifecycle.MakePersistentAndInstancesNotReachable.createObjects(MakePersistentAndInstancesNotReachable.java:85)
at org.apache.jdo.tck.api.persistencemanager.lifecycle.MakePersistentAndInstancesNotReachable.test(MakePersistentAndInstancesNotReachable.java:69)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:203)
at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:128)
at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:106)
NestedThrowablesStackTrace:
ERROR 42X14: 'ADDRID' is not a column in table or VTI 'DATASTOREIDENTITY0.COMPANIES'.
at org.apache.derby.iapi.error.StandardException.newException(StandardException.java)
at org.apache.derby.impl.sql.compile.ResultColumn.bindResultColumnByName(ResultColumn.java)
at org.apache.derby.impl.sql.compile.ResultColumnList.bindResultColumnsByName(ResultColumnList.java)
at org.apache.derby.impl.sql.compile.InsertNode.bind(InsertNode.java)
at org.apache.derby.impl.sql.GenericStatement.prepMinion(GenericStatement.java)
at org.apache.derby.impl.sql.GenericStatement.prepare(GenericStatement.java)
at org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareInternalStatement(GenericLanguageConnectionContext.java)
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(EmbedPreparedStatement.java)
at org.apache.derby.impl.jdbc.EmbedPreparedStatement20.<init>(EmbedPreparedStatement20.java)
at org.apache.derby.impl.jdbc.EmbedPreparedStatement30.<init>(EmbedPreparedStatement30.java)
at org.apache.derby.jdbc.Driver30.newEmbedPreparedStatement(Driver30.java)
at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(EmbedConnection.java)
at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(EmbedConnection.java)
at com.mchange.v2.c3p0.impl.NewProxyConnection.prepareStatement(NewProxyConnection.java:303)
at org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:153)
at org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:1735)
at org.jpox.store.StoreManager.insert(StoreManager.java:663)
at org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3088)
at org.jpox.state.StateManagerImpl.makePersistent(StateManagerImpl.java:3061)
at org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:976)
at org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1012)
at org.apache.jdo.tck.api.persistencemanager.lifecycle.MakePersistentAndInstancesNotReachable.createObjects(MakePersistentAndInstancesNotReachable.java:85)
at org.apache.jdo.tck.api.persistencemanager.lifecycle.MakePersistentAndInstancesNotReachable.test(MakePersistentAndInstancesNotReachable.java:69)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:203)
at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:128)
at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:106)

Comments

[Michelle Caisse]

From Craig Russell:

The addrid field is a persistent field in the application domain, and should be mapped in both application and datastore identity cases. I think the easiest way to do it is to add field mapping and column ADDRID to the schema and mapping files. Even though addrid is not the identity field, it's still a persistent field in the model and needs to be mapped.

I also notice that in the package.jdo for the company model, Address is defined thus:

        <class name="Address" requires-extent="false">
            <field name="addrid" persistence-modifier="none"/>
        </class>

This isn't right, as the addrid field is an application field that needs to be set to the application value in order for comparisons to succeed.

[Michael Bouschen]

Reopened to set the Fix Version/s field to JDO 2 beta.