Issue Details (XML | Word | Printable)

Key: JDO-524
Type: Test Test
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Michael Bouschen
Reporter: Ilan Kirsh
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
JDO

SELECT lastname INTO java.lang.Long - is a negative test?

Created: 06/Sep/07 03:30 PM   Updated: 13/Sep/07 09:41 PM
Component/s: tck2
Affects Version/s: JDO 2 final
Fix Version/s: JDO 2 maintenance release 1

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works JDO-524.patch 2007-09-12 10:03 PM Michael Bouschen 1 kB

Resolution Date: 13/Sep/07 09:41 PM


 Description  « Hide
The second negative test query in org.apache.jdo.tck.query.result.ResultClassRequirements is:
  "SELECT lastname INTO java.lang.Long FROM org.apache.jdo.tck.pc.company.FullTimeEmployee".

Exception is expected by the test, but because java.lang.Long has a constructor with one string argument - this query should be valid, unless the spec defines special rules for java.lang wrapper types as result types.


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Craig Russell added a comment - 07/Sep/07 04:21 PM
Changing the type of the selected element from lastname to something else should fix this.

Craig Russell made changes - 07/Sep/07 04:21 PM
Field Original Value New Value
Assignee Michael Bouschen [ mbo ]
Michael Bouschen added a comment - 12/Sep/07 10:03 PM
I propose to change the SELECT clause to select the FullTimeEmployee instance, i.e.
SELECT this INTO java.lang.Long FROM org.apache.jdo.tck.pc.company.FullTimeEmployee

Attached you find a patch changing the query in tck2 and tck2-legacy.

Michael Bouschen made changes - 12/Sep/07 10:03 PM
Attachment JDO-524.patch [ 12365675 ]
Craig Russell added a comment - 12/Sep/07 10:09 PM
Looks good.

Repository Revision Date User Message
ASF #575469 Thu Sep 13 21:39:41 UTC 2007 mbo JDO-524: fix SELECT clause of negative test in ResultClassEnvironment
Files Changed
MODIFY /db/jdo/trunk/tck2-legacy/src/java/org/apache/jdo/tck/query/result/ResultClassRequirements.java
MODIFY /db/jdo/trunk/tck2/src/java/org/apache/jdo/tck/query/result/ResultClassRequirements.java

Michael Bouschen added a comment - 13/Sep/07 09:41 PM
Checked in the patch (see revision 575469).

Michael Bouschen made changes - 13/Sep/07 09:41 PM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s JDO 2 maintenance release 1 [ 12310923 ]
Resolution Fixed [ 1 ]