StateTransitionsReturnedObjects expects persistent-clean in optimistic transaction

• Key: JDO-513
• Type: Test
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Andy Jefferson
• Reporter: Ilan Kirsh
• Component/s: tck2
• Fix Version/s: JDO 2 maintenance release 1

Description

StateTransitionsReturnedObjects fails with:

junit.framework.AssertionFailedError:
Assertions A5.9-1 through A5.5.8 (serialization, detachment, attachment) failed:
StateTransitionsReturnedObjects: optimistic transaction; current state detached-clean
makePersistent returned instance in invalid state hollow; expected state persistent-clean

It seems that in optimistic transaction the object state should be non transactional.

Comments

[Craig Russell]

The specification doesn't explicitly cover this case, although I agree that the state transition should be as you indicate. The state transition table 2 near 5.8 has an entry for makePersistent but doesn't split out datastore transaction versus optimistic transaction.

For now, we can mark this test case as UNSPECIFIED and document and fix it in maintenance (both the specification and the test case).

[Craig Russell]

The specification dated 2007-09-28 has been updated to split the row in the state transitions table so that the returned state in datastore transaction is persistent-clean but in optimistic transaction is persistent-nontransactional.

The test case needs to be updated now.

[Craig Russell]

Since the spec was deficient, the branch for test case challenges should be updated to skip this test, and the trunk should be updated to check for persistent-clean for datastore transactions and persistent-nontransactional for optimistic.

The spec was updated to reflect that with an optimistic transaction, makePersistent transitions detached instances to persistent-nontransactional:

This change now makes JPOX fail the StateTransitionsReturnedObjects test.

[Andy Jefferson]

JPOX SVN has been changed to match the moved goalposts of the TCK, now passes