setUp() is not declared final in org.apache.jdo.tck.JDO_Test

• Key: JDO-433
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Michelle Caisse
• Reporter: Michelle Caisse
• Component/s: tck2
• Affects Version/s: JDO 2 final
• Fix Version/s: JDO 2 maintenance release 1

Description

Tests are to override localSetUp() for test specific set up. The setUp() method in JDO_Test is not meant to be overriden. However, it is not currently declared to be final. It should be declared final and the set up code in the tests that do override setUp() (listed below) should be in localSetUp().

C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManager.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerFactoryByPropertiesInstance.java:60: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerFactoryByPropertiesInstance cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\GetPersistenceManagerForUser.java:63: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionPassword.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionPassword cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionURL.java:58: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionURL cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetConnectionUserName.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionUserName cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetIgnoreCache.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetIgnoreCache cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetMultithreaded.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetMultithreaded cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalRead.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalRead cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetNonTransactionalWrite.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalWrite cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetOptimistic.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetOptimistic cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^
C:\svn0\jdo\trunk\tck20\src\java\org\apache\jdo\tck\api\persistencemanagerfactory\SetRetainValues.java:55: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetRetainValues cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
   protected void setUp() throws Exception {
                  ^

Comments

[Michelle Caisse]

Michael Watzek points out that JDO_Test.runBare() should also be declared final.

[Michelle Caisse]

Patch to resolve this issue is attached. Affects JDO_Test.java and a number of tests in the persistencemanagerfactory package.

[Craig Russell]

Looks good. Just one comment.

I don't think we need the localSetUp method to call closePMF, since that is always done by tearDown (9 places).

[Michelle Caisse]

If we don't closePMF, the call to getUnconfiguredPMF() returns the standard PMF that is created by the setUp() method in the parent class before its call to localSetUp(). It seems to me that getUnconfiguredPMF() should either throw an exception or close the existing pmf itself if pmf is not null, rather than returning something which the caller may not want.

[Craig Russell]

Ok, you win. ;-)

Craig

[Michelle Caisse]

Fixed with revision: 540316