[#JDO-429] StateTransitionsReturnedObjects assumes that serializing deleted instances will transition them to transient

JDO

StateTransitionsReturnedObjects assumes that serializing deleted instances will transition them to transient

Created: 17/Sep/06 06:51 AM Updated: 10/Oct/06 07:44 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 TCK challenge fixes

Time Tracking:

Not Specified

Resolution Date:

10/Oct/06 07:44 PM

Description

« Hide

Elements 7 and 8 (0-based) of the "serialize with active tx" array in org/apache/jdo/tck/lifecycle/StateTransitionsReturnedObjects.java assert that a persistent-new-deleted and persistent-deleted instance (respectively) will transition to transient when then are serialized then deserialized. However, the specification does not seem to mandate this anywhere: detached-clean should be an equally valid state to be in.

The easiest fix, short of changing the test case to allow for multiple states, is to change elements 7 and 8 from "TRANSIENT" to "IMPOSSIBLE", which will disable the state check altogether.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Marc Prud'hommeaux added a comment - 17/Sep/06 06:58 AM

The same goes for element 10 of "serialize outside tx", which asserts that a persistent-nontransactional-dirty instance will become transient after serialize/deserialize, even though the specification seems to never mandate this. detached-clean should be an equally valid assertion.

[ Permlink | « Hide ]

Craig Russell added a comment - 04/Oct/06 03:22 PM

The intent of a detached instance is that it represents a persistent instance that is not actively managed by a PersistenceManager but has identity and can be attached to a PersistenceManager. In the case of a deleted instance, this concept is violated and will cause problems for the application.

Specifically, if a deleted instance is treated as detached, and the detached instance is subsequently attached, an exception should result because the instance no longer exists in the datastore, and the assumption is that detached instances have persistent identity that corresponds to a persistent instance.

Regarding element 10, persistent-nontransactional-dirty, I will create another JIRA for this, since it's a separate issue.

Craig Russell made changes - 04/Oct/06 09:18 PM

Field	Original Value	New Value
Assignee		Craig Russell [ clr ]

Craig Russell made changes - 04/Oct/06 09:18 PM

Fix Version/s		JDO 2 maintenance release 1 [ 12310923 ]
Fix Version/s		JDO 2.0 TCK challenge fixes [ 12312093 ]

Repository	Revision	Date	User	Message
ASF	#462525	Tue Oct 10 19:43:35 UTC 2006	clr	~~JDO-427~~ ~~JDO-429~~ ~~JDO-431~~ StateTransitionsReturnedObjects.java is modified to make several state transitions UNSPECIFIED, since the specification is ambiguous. These changes apply only to the branches/2.0.1, as we intend to clarify the specification for JDO 2.1 maintenance release.
				Files Changed
				MODIFY /db/jdo/branches/2.0.1/tck20/src/java/org/apache/jdo/tck/lifecycle/StateTransitionsReturnedObjects.java

[ Permlink | « Hide ]

Craig Russell added a comment - 10/Oct/06 07:44 PM

svn commit src/java/org/apache/jdo/tck/lifecycle/StateTransitionsReturnedObjects.java
Sending src/java/org/apache/jdo/tck/lifecycle/StateTransitionsReturnedObjects.java
Transmitting file data .
Committed revision 462525.

Craig Russell made changes - 10/Oct/06 07:44 PM

Fix Version/s	JDO 2 maintenance release 1 [ 12310923 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]