[#JDO-424] StateTransitions makes undocumented assertions in detachCopy with active tx

JDO

StateTransitions makes undocumented assertions in detachCopy with active tx

Created: 13/Sep/06 02:15 AM Updated: 09/Oct/06 10:43 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 maintenance release 1, JDO 2 TCK challenge fixes

Time Tracking:

Not Specified

Resolution Date:

09/Oct/06 10:43 PM

Description

« Hide

In StateTransitions.java, a couple of the transition assertions that are made in the "detachCopy with active tx" scenario are not documented:

Element 4 (0-based) asserts that HOLLOW will remain UNCHANGED when detachCopy() is called on them. However, this doesn't seem to be anywhere in the spec, and also doesn't seem right, since a hollow instance would need to instantiate its fields in order to cascade the detach operation (subject to the setting of the DETACH_LOAD_FIELDS setting).

Element 9 asserts that a PERSISTENT_NONTRANSACTIONAL instance will remain unchanged. However, for the same reason as above, it might transition to persistent-clean due to reading a field.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Craig Russell made changes - 02/Oct/06 08:21 PM

Field	Original Value	New Value
Assignee		Craig Russell [ clr ]

[ Permlink | « Hide ]

Craig Russell added a comment - 04/Oct/06 01:42 AM

I agree that this behavior is not specified, so I propose changing the UNCHANGED in the two cases to UNSPECIFIED.

Craig Russell made changes - 04/Oct/06 09:21 PM

Fix Version/s		JDO 2 maintenance release 1 [ 12310923 ]
Fix Version/s		JDO 2.0 TCK challenge fixes [ 12312093 ]

Repository	Revision	Date	User	Message
ASF	#454538	Mon Oct 09 22:42:57 UTC 2006	clr	~~JDO-419~~ ~~JDO-424~~ Changed state transition table to use UNSPECIFIED where the specification is unclear
				Files Changed
				MODIFY /db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/lifecycle/StateTransitions.java MODIFY /db/jdo/branches/2.0.1/tck20/src/java/org/apache/jdo/tck/lifecycle/StateTransitions.java

[ Permlink | « Hide ]

Craig Russell added a comment - 09/Oct/06 10:43 PM

svn commit -m "~~JDO-419~~ ~~JDO-424~~ Changed state transition table to use UNSPECIFIED where the specification is unclear" trunk/tck20/src/java/org/apache/jdo/tck/lifecycle/StateTransitions.java branches/2.0.1/tck20/src/java/org/apache/jdo/tck/lifecycle/StateTransitions.java
Sending branches/2.0.1/tck20/src/java/org/apache/jdo/tck/lifecycle/StateTransitions.java
Sending trunk/tck20/src/java/org/apache/jdo/tck/lifecycle/StateTransitions.java
Transmitting file data ..
Committed revision 454538.

Craig Russell made changes - 09/Oct/06 10:43 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]