Enhancer log contains ERRORs, but output appears to be fine

• Key: JDO-421
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Michelle Caisse
• Reporter: Michelle Caisse
• Component/s: tck2
• Affects Version/s: JDO 2 maintenance release 1

Description

There are numerous errors in the enhancer log, yet the enhancer runs to completion and produces valid output. These messages should be warnings at most.

17:12:15,804 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "package.jdo" at line 9, column 47 : Document root element "jdo", must match DOCTYPE root "null". - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:15,804 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "package.jdo" at line 9, column 47 : Document is invalid: no grammar found. - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:16,104 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/api/instancecallbacks/package.jdo" at line 8, column 47 : Document root element "jdo", must match DOCTYPE root "null". - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:16,104 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/api/instancecallbacks/package.jdo" at line 8, column 47 : Document is invalid: no grammar found. - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:16,795 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/company/package.jdo" at line 5, column 47 : Document root element "jdo", must match DOCTYPE root "null". - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:16,795 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/company/package.jdo" at line 5, column 47 : Document is invalid: no grammar found. - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:17,015 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/companyMapWithoutJoin/package.jdo" at line 5, column 47 : Document root element "jdo", must match DOCTYPE root "null". - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:17,015 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/companyMapWithoutJoin/package.jdo" at line 5, column 47 : Document is invalid: no grammar found. - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:17,055 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/fieldtypes/AllTypes.jdo" at line 5, column 47 : Document root element "jdo", must match DOCTYPE root "null". - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:17,055 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/fieldtypes/AllTypes.jdo" at line 5, column 47 : Document is invalid: no grammar found. - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

17:12:17,065 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/fieldtypes/ArrayCollections.jdo" at line 5, column 47 : Document root element "jdo", must match DOCTYPE root "null". - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

...

Comments

[Andy Jefferson]

These are warnings in JPOX CVS.
As I posted on the mailing list a long time ago, if you add
org.jpox.metadata.validate=false

to
trunk/tck20/src/conf/jdori-pmf.properties
you wont get any of that.

[Andy Jefferson]

Patch to fix logging categories to remove dup entries.

[Craig Russell]

I think that there is value in having validation without requiring a connection to the Sun server where the xsd is defined. Don't you have a copy of the xsd cached in JPOX somewhere, so you can validate without being online?

[Andy Jefferson]

It isn't a question of having xsd cached somewhere. JPOX metadata parsing does not support validation using XML Schema, only via DTD. If you want to contribute support for XSD validation in JPOX that would be welcome and there's a JIRA already existing for it. We have other priorities right now.

[Craig Russell]

I wasn't trying to make a distinction between validation via xsd or dtd. I was only making the point that the fact that there is no dtd or xsd at the URI should not affect your ability to validate. Using an EntityResolver with your xml parser allows you to use the dtd or xsd reference as a key to use a cached local artifact instead of going online.

I appreciate you have priorities other than these.

[Craig Russell]

Considering that this is only a JPOX issue, and the TCK doesn't need to validate schema, I think Andy's proposed patch to jdori-pmf.properties is a good solution.

I'm not clear on all the changes to log4j.properties, though. Could you please annotate the changes?

 # JPOX loggers
 log4j.logger.JPOX = INFO, JPOX
-log4j.additivity.JPOX = false
+log4j.additivity.JPOX = false

Ok, this removes a trailing blank.

 #log4j.logger.JPOX.JDO = INFO, JPOX
 #log4j.logger.JPOX.Cache = INFO, JPOX
-#log4j.logger.JPOX.MetaData = INFO, JPOX
+#log4j.logger.JPOX.MetaData = DEBUG, JPOX

This appears to add more metdata information to the log, correct?

 #log4j.logger.JPOX.General = DEBUG, JPOX
 #log4j.logger.JPOX.Utility = INFO, JPOX
 #log4j.logger.JPOX.Transaction = INFO, JPOX
@@ -64,7 +64,8 @@
 #log4j.logger.JPOX.RDBMS = DEBUG, JPOX
 
 log4j.logger.JPOX.Enhancer = INFO, JPOX
-log4j.logger.JPOX.SchemaTool = INFO, JPOX

The following line (+2) seems to comment this line. Could you explain why?

+log4j.additivity.JPOX.Enhancer = false

I don't know what this change does.

+#log4j.logger.JPOX.SchemaTool = INFO, JPOX

[Andy Jefferson]

Sorry for the lack of description of the log changes.

This line removes duplicate entries in the Log4J log (a message is printed twice if you dont put this in)
+log4j.additivity.JPOX.Enhancer = false
That is really the only change.

The one about SchemaTool was just moving it down a line but patch decided to take it out and then add it back in later. The one about log4j.logger.JPOX.MetaData is commented out anyway and so you can omit ;-) Hope thats clearer.

[Michelle Caisse]

Thanks for the patches. I applied them, but still get the errors reported above. I verified that jdori-pmf.properties is being read and that it contains org.jpox.metadata.validate=false.

[Andy Jefferson]

JPOX CVS supports XSD validation using local copies of xsd files assuming that the underlying SAXParser supports it ... and Crimson in JDK1.4 doesnt, though JDK1.5 does.

[Craig Russell]

Need to verify against latest JPOX release.

[Michelle Caisse]

Fixed with revision: 453315
Verified that with the current JPOX, these patches, and JDK 1.5, there are no error messages in the enhancer log.