DataStoreConnection assumes datastore transactions are being used

• Key: JDO-415
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Craig Russell
• Reporter: Marc Prud'hommeaux
• Component/s: tck2
• Affects Version/s: JDO 2 final
• Fix Version/s: JDO 2 maintenance release 1, JDO 2 TCK challenge fixes

Description

org.apache.jdo.tck.api.persistencemanager.DataStoreConnection assumes that the connection returned from getDataStoreConnection will be re-used once a JDO transaction is started, but that assertion is only valid when using datastore transactions, and the test case does not ensure that a datastore transaction is being used.

The solution is to call "getPM().currentTransaction().setOptimistic(false);" just before "getPM().currentTransaction().begin();" in the testDataStoreConnection() test case.

Comments

[Craig Russell]

Please review this patch.

There are three problems with the original test case.

1. As the bug noted, the DataStoreConnection is acquired outside a transaction, and there is no guarantee that the DataStoreConnection is even valid after beginning a transaction. So I changed the code to acquire the DataStoreConnection only after beginning a transaction.

2. If the implementation supports Optimistic transactions, then the test should be repeated for both optimistic and datastore transactions.

3. The transaction is never committed. This is fixed by putting the DataStoreConnection close and the transaction.commit into the finally block.

[Michael Bouschen]

The patch looks good!

[Craig Russell]

svn commit src/java/org/apache/jdo/tck/api/persistencemanager
Sending src/java/org/apache/jdo/tck/api/persistencemanager/DataStoreConnection.java
Transmitting file data .
Committed revision 453089.

Commit for the branch/2.0.1

svn commit -m "JDO-415"
Sending tck20/src/java/org/apache/jdo/tck/api/persistencemanager/DataStoreConnection.java
Transmitting file data .
Committed revision 453090.