[#JDO-404] GetFetchPlan - Is it really forbidden to load extra fields?

JDO

GetFetchPlan - Is it really forbidden to load extra fields?

Created: 09/Aug/06 08:18 AM Updated: 05/Oct/06 03:19 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 maintenance release 1, JDO 2 TCK challenge fixes

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	JDO-404.patch	2006-10-04 09:28 PM	Michael Bouschen	4 kB

Resolution Date:

05/Oct/06 03:19 PM

Description

« Hide

The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):

"When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Craig Russell made changes - 10/Aug/06 11:12 PM

Field	Original Value	New Value
Fix Version/s		JDO 2 maintenance release 1 [ 12310923 ]

Craig Russell made changes - 10/Aug/06 11:28 PM

Assignee

Craig Russell [ clr ]

Craig Russell made changes - 04/Oct/06 08:58 PM

Assignee

Craig Russell [ clr ]

Michael Bouschen [ mbo ]

Craig Russell made changes - 04/Oct/06 08:59 PM

Fix Version/s

JDO 2.0 TCK challenge fixes [ 12312093 ]

[ Permlink | « Hide ]

Michael Bouschen added a comment - 04/Oct/06 09:28 PM

I agree. Since the implementation may choose to use the active fetch groups to prefetch data, the test cannot test this behaviour.

The attached patch for review removes the code from the test class that checks whether fields are loaded because a ceratin fetch group is active. The test still checks whether multiple calls of getFetchPlan return the identical instacne and whether addGroup/removeGroup modify the current fetch plan.

Michael Bouschen made changes - 04/Oct/06 09:28 PM

Attachment

JDO-404.patch [ 12342290 ]

[ Permlink | « Hide ]

Ilan Kirsh added a comment - 04/Oct/06 10:24 PM

The patch seems to do the trick. Thanks.

[ Permlink | « Hide ]

Craig Russell added a comment - 04/Oct/06 11:57 PM

The patch looks good.

Repository	Revision	Date	User	Message
ASF	#453265	Thu Oct 05 15:19:13 UTC 2006	mbo	~~JDO-404~~: changed test GetFetchPlan to not check whether fields are loaded because a certain fetch group is active
				Files Changed
				MODIFY /db/jdo/branches/2.0.1/tck20/src/java/org/apache/jdo/tck/query/api/GetFetchPlan.java MODIFY /db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/query/api/GetFetchPlan.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 05/Oct/06 03:19 PM

Checked in the patch (see revision 453265).

Michael Bouschen made changes - 05/Oct/06 03:19 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]