GetFetchPlan - Is it really forbidden to load extra fields?

• Key: JDO-404
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Michael Bouschen
• Reporter: Ilan Kirsh
• Component/s: tck2
• Affects Version/s: JDO 2 final
• Fix Version/s: JDO 2 maintenance release 1, JDO 2 TCK challenge fixes

Description

The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):

"When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...

Comments

[Michael Bouschen]

I agree. Since the implementation may choose to use the active fetch groups to prefetch data, the test cannot test this behaviour.

The attached patch for review removes the code from the test class that checks whether fields are loaded because a ceratin fetch group is active. The test still checks whether multiple calls of getFetchPlan return the identical instacne and whether addGroup/removeGroup modify the current fetch plan.

The patch seems to do the trick. Thanks.

[Craig Russell]

The patch looks good.

[Michael Bouschen]

Checked in the patch (see revision 453265).