[#JDO-400] IsTransactionalFalse - Should work with optimistic transactions?

JDO

IsTransactionalFalse - Should work with optimistic transactions?

Created: 25/Jul/06 07:23 AM Updated: 03/Oct/06 10:08 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 maintenance release 1, JDO 2 TCK challenge fixes

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	JDO-400.patch	2006-07-30 01:15 AM	Craig Russell	0.6 kB

Resolution Date:

30/Jul/06 08:01 PM

Description

« Hide

org.apache.jdo.tck.api.jdohelper.IsTransactionalFalse fails if in line 86 p1 is not persistent clean, but if the transaction is optimistic p1 is expected to be persistent non transactional, doesn't it?

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Craig Russell added a comment - 29/Jul/06 08:02 PM

Need to resolve these issues for maintenance release 1.

[ Permlink | « Hide ]

Craig Russell added a comment - 30/Jul/06 01:15 AM

Right. The transaction in which the instance is touched must be datastore, not optimistic.

The attached patch explicitly marks the transaction as datastore in order to reliably make the instance transactional.

[ Permlink | « Hide ]

Michael Bouschen added a comment - 30/Jul/06 06:28 PM

The patch looks good!

[ Permlink | « Hide ]

Craig Russell added a comment - 30/Jul/06 08:01 PM

svn commit -m "~~JDO-400~~ Set transaction type to datastore explicitly so instance read becomes transactional" src/java/org/apache/jdo/tck/api/jdohelper/IsTransactionalFalse.java
Sending src/java/org/apache/jdo/tck/api/jdohelper/IsTransactionalFalse.java
Transmitting file data .
Committed revision 426928.

[ Permlink | « Hide ]

Michael Bouschen added a comment - 03/Oct/06 09:28 PM

I merged the change from the trunk into brach 2.0.1 (see revision 452630).