[#JDO-395] org.apache.jdo.tck.lifecycle.NontransactionalWriteTest.conflictingUpdate() don't cleanup correctly in case of an Exception

JDO

org.apache.jdo.tck.lifecycle.NontransactionalWriteTest.conflictingUpdate() don't cleanup correctly in case of an Exception

Created: 19/Jul/06 09:24 AM Updated: 04/Oct/06 07:17 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 maintenance release 1, JDO 2 TCK challenge fixes

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	NontransactionalWriteTest.java.patch	2006-07-19 09:26 AM	Christian Ernst	0.9 kB

Resolution Date:

19/Jul/06 06:54 PM

Description

« Hide

org.apache.jdo.tck.lifecycle.NontransactionalWriteTest.conflictingUpdate() don't cleanup correctly in case of an Exception

The cleanupPM(pmConflict); should be sourounded by a finaly block

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Christian Ernst added a comment - 19/Jul/06 09:26 AM

Patch

[ Permlink | « Hide ]

Craig Russell added a comment - 19/Jul/06 05:36 PM

Thanks for the patch. It looks good except for the tabs.

[Our standard is for indentation to be done via 4 spaces, not tabs.]

[ Permlink | « Hide ]

Michael Bouschen added a comment - 19/Jul/06 06:54 PM

Thanks for the patch.

I appied the same change (move cleanupPM to a finally block) to method checkXValue,
changed the indentation and checked in the fix (see revision 423563).

[ Permlink | « Hide ]

Michael Bouschen added a comment - 04/Oct/06 07:17 PM

I merged the change from the trunk into branch 2.0.1 (see revision 452982).