[#JDO-395] org.apache.jdo.tck.lifecycle.NontransactionalWriteTest.conflictingUpdate() don't cleanup correctly in case of an Exception

JDO

org.apache.jdo.tck.lifecycle.NontransactionalWriteTest.conflictingUpdate() don't cleanup correctly in case of an Exception

Created: 19/Jul/06 09:24 AM Updated: 04/Oct/06 07:17 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 maintenance release 1, JDO 2 TCK challenge fixes

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	NontransactionalWriteTest.java.patch	2006-07-19 09:26 AM	Christian Ernst	0.9 kB

Resolution Date:

19/Jul/06 06:54 PM

Description

« Hide

org.apache.jdo.tck.lifecycle.NontransactionalWriteTest.conflictingUpdate() don't cleanup correctly in case of an Exception

The cleanupPM(pmConflict); should be sourounded by a finaly block

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Christian Ernst added a comment - 19/Jul/06 09:26 AM

Patch

Christian Ernst made changes - 19/Jul/06 09:26 AM

Field	Original Value	New Value
Attachment		NontransactionalWriteTest.java.patch [ 12337150 ]

[ Permlink | « Hide ]

Craig Russell added a comment - 19/Jul/06 05:36 PM

Thanks for the patch. It looks good except for the tabs.

[Our standard is for indentation to be done via 4 spaces, not tabs.]

Repository	Revision	Date	User	Message
ASF	#423563	Wed Jul 19 18:50:36 UTC 2006	mbo	~~JDO-395~~: fix cleaning up the PM in NontransactionalWriteTest
				Files Changed
				MODIFY /db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/lifecycle/NontransactionalWriteTest.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 19/Jul/06 06:54 PM

Thanks for the patch.

I appied the same change (move cleanupPM to a finally block) to method checkXValue,
changed the indentation and checked in the fix (see revision 423563).

Michael Bouschen made changes - 19/Jul/06 06:54 PM

Assignee		Michael Bouschen [ mbo ]
Fix Version/s		JDO 2 maintenance release 1 [ 12310923 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Repository	Revision	Date	User	Message
ASF	#452982	Wed Oct 04 19:12:49 UTC 2006	mbo	~~JDO-399~~, ~~JDO-395~~: merge changes from trunk into branch 2.0.1
				Files Changed
				MODIFY /db/jdo/branches/2.0.1/tck20/src/java/org/apache/jdo/tck/lifecycle/NontransactionalWriteTest.java

[ Permlink | « Hide ]

Michael Bouschen added a comment - 04/Oct/06 07:17 PM

I merged the change from the trunk into branch 2.0.1 (see revision 452982).

Michael Bouschen made changes - 04/Oct/06 07:17 PM

Fix Version/s

JDO 2.0 TCK challenge fixes [ 12312093 ]