[#JDO-380] Missing pm.close() in GetPersistenceManagerFactory

JDO

Missing pm.close() in GetPersistenceManagerFactory

Created: 16/May/06 10:12 AM Updated: 29/Jul/06 10:40 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 maintenance release 1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	JDO-380.patch	2006-07-29 10:14 PM	Michael Bouschen	1 kB

Resolution Date:

29/Jul/06 10:40 PM

Description

« Hide

I suspect that pm.close() is missing at the end of method testGetPersistenceManagerFactory().

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael Bouschen added a comment - 19/May/06 07:41 PM

I agree, the pm should be closed at the end of the test.

I propose to change GetPersistenceManagerFactory in package tck.api.persistencemanager and use method getPM to retrieve a pm. It stores the pm in an instance variable and the tearDown method automatically closes the pm at the end of the test.

Michael Bouschen made changes - 19/May/06 07:41 PM

Field	Original Value	New Value
Assignee		Michael Bouschen [ mbo ]
Affects Version/s		JDO 2 final [ 12310830 ]
Fix Version/s		JDO 2 maintenance release 1 [ 12310923 ]

[ Permlink | « Hide ]

Michael Bouschen added a comment - 29/Jul/06 10:14 PM

The attached patch calls getPM to retrieve the PM and closes the PM.

Michael Bouschen made changes - 29/Jul/06 10:14 PM

Attachment

JDO-380.patch [ 12337755 ]

[ Permlink | « Hide ]

Craig Russell added a comment - 29/Jul/06 10:37 PM

The patch looks good.

[ Permlink | « Hide ]

Michael Bouschen added a comment - 29/Jul/06 10:40 PM

Checked in the patch (revision 426846).

Michael Bouschen made changes - 29/Jul/06 10:40 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ASF	#426846	Sat Jul 29 22:41:25 UTC 2006	mbo	~~JDO-380~~: Missing pm.close() in GetPersistenceManagerFactory
				Files Changed
				MODIFY /db/jdo/trunk/tck20/src/java/org/apache/jdo/tck/api/persistencemanager/GetPersistenceManagerFactory.java