[#JDO-380] Missing pm.close() in GetPersistenceManagerFactory

JDO

Missing pm.close() in GetPersistenceManagerFactory

Created: 16/May/06 10:12 AM Updated: 29/Jul/06 10:40 PM

Return to search

Component/s:

tck2

Affects Version/s:

JDO 2 final

Fix Version/s:

JDO 2 maintenance release 1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	JDO-380.patch	2006-07-29 10:14 PM	Michael Bouschen	1 kB

Resolution Date:

29/Jul/06 10:40 PM

Description

« Hide

I suspect that pm.close() is missing at the end of method testGetPersistenceManagerFactory().

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael Bouschen added a comment - 19/May/06 07:41 PM

I agree, the pm should be closed at the end of the test.

I propose to change GetPersistenceManagerFactory in package tck.api.persistencemanager and use method getPM to retrieve a pm. It stores the pm in an instance variable and the tearDown method automatically closes the pm at the end of the test.

[ Permlink | « Hide ]

Michael Bouschen added a comment - 29/Jul/06 10:14 PM

The attached patch calls getPM to retrieve the PM and closes the PM.

[ Permlink | « Hide ]

Craig Russell added a comment - 29/Jul/06 10:37 PM

The patch looks good.

[ Permlink | « Hide ]

Michael Bouschen added a comment - 29/Jul/06 10:40 PM

Checked in the patch (revision 426846).