[#JDO-353] Fix issues reported by checkstyle in api20 subproject

JDO

Fix issues reported by checkstyle in api20 subproject

Created: 29/Mar/06 12:36 AM Updated: 29/Mar/06 07:14 AM

Return to search

Component/s:

api2

Affects Version/s:

JDO 2 rc1

Fix Version/s:

JDO 2 final

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	JDO-353.patch	2006-03-29 03:05 AM	Michael Bouschen	101 kB

Resolution Date:

29/Mar/06 07:14 AM

Description

« Hide

Today I did a maven site on the api20 subproject. This includes running checkstyle on the api20 sources which reports 83 "errors". These are not real errors, but maybe cleanup items we want to do before shipping: lines being longer than 100 chars, unused imports, file not ending with a newline, array brackets at illegal position.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Michael Bouschen added a comment - 29/Mar/06 03:06 AM

Please review the attached patch ~~JDO-353~~.patch.

[ Permlink | « Hide ]

Craig Russell added a comment - 29/Mar/06 05:45 AM

A few of the lines now or still exceed 80 characters. Can you run the stlyecheck again with the new files?

These are the files I found where the changed file still contains lines > 80 characters:

src/java/javax/jdo/listener/AttachCallback.java
src/java/javax/jdo/Query.java
src/java/javax/jdo/PersistenceManagerFactory.java
src/java/javax/jdo/spi/JDOPermission.java
src/java/javax/jdo/spi/StateManager.java
src/java/javax/jdo/spi/JDOImplHelper.java
src/java/javax/jdo/JDOHelper.java
src/java/javax/jdo/PersistenceManager.java
src/java/javax/jdo/Transaction.java

I didn't find anything else to complain about.

[ Permlink | « Hide ]

Michael Bouschen added a comment - 29/Mar/06 07:14 AM

Checked in the fix.

Sende api20\src\java\javax\jdo\JDODetachedFieldAccessException.java
Sende api20\src\java\javax\jdo\JDOHelper.java
Sende api20\src\java\javax\jdo\JDOOptimisticVerificationException.java
Sende api20\src\java\javax\jdo\PersistenceManager.java
Sende api20\src\java\javax\jdo\PersistenceManagerFactory.java
Sende api20\src\java\javax\jdo\Query.java
Sende api20\src\java\javax\jdo\Transaction.java
Sende api20\src\java\javax\jdo\datastore\JDOConnection.java
Sende api20\src\java\javax\jdo\datastore\Sequence.java
Sende api20\src\java\javax\jdo\identity\ObjectIdentity.java
Sende api20\src\java\javax\jdo\identity\StringIdentity.java
Sende api20\src\java\javax\jdo\listener\AttachCallback.java
Sende api20\src\java\javax\jdo\listener\AttachLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\ClearLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\CreateLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\DeleteLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\DetachCallback.java
Sende api20\src\java\javax\jdo\listener\DetachLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\DirtyLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\InstanceLifecycleEvent.java
Sende api20\src\java\javax\jdo\listener\InstanceLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\LoadLifecycleListener.java
Sende api20\src\java\javax\jdo\listener\StoreLifecycleListener.java
Sende api20\src\java\javax\jdo\spi\I18NHelper.java
Sende api20\src\java\javax\jdo\spi\JDOImplHelper.java
Sende api20\src\java\javax\jdo\spi\JDOPermission.java
Sende api20\src\java\javax\jdo\spi\PersistenceCapable.java
Sende api20\src\java\javax\jdo\spi\StateInterrogation.java
Sende api20\src\java\javax\jdo\spi\StateManager.java
?\195?\156bertrage Daten .............................
Revision 389615 ?\195?\188bertragen.

[ Show » ]

Michael Bouschen added a comment - 29/Mar/06 07:14 AM Checked in the fix. Sende api20\src\java\javax\jdo\JDODetachedFieldAccessException.java Sende api20\src\java\javax\jdo\JDOHelper.java Sende api20\src\java\javax\jdo\JDOOptimisticVerificationException.java Sende api20\src\java\javax\jdo\PersistenceManager.java Sende api20\src\java\javax\jdo\PersistenceManagerFactory.java Sende api20\src\java\javax\jdo\Query.java Sende api20\src\java\javax\jdo\Transaction.java Sende api20\src\java\javax\jdo\datastore\JDOConnection.java Sende api20\src\java\javax\jdo\datastore\Sequence.java Sende api20\src\java\javax\jdo\identity\ObjectIdentity.java Sende api20\src\java\javax\jdo\identity\StringIdentity.java Sende api20\src\java\javax\jdo\listener\AttachCallback.java Sende api20\src\java\javax\jdo\listener\AttachLifecycleListener.java Sende api20\src\java\javax\jdo\listener\ClearLifecycleListener.java Sende api20\src\java\javax\jdo\listener\CreateLifecycleListener.java Sende api20\src\java\javax\jdo\listener\DeleteLifecycleListener.java Sende api20\src\java\javax\jdo\listener\DetachCallback.java Sende api20\src\java\javax\jdo\listener\DetachLifecycleListener.java Sende api20\src\java\javax\jdo\listener\DirtyLifecycleListener.java Sende api20\src\java\javax\jdo\listener\InstanceLifecycleEvent.java Sende api20\src\java\javax\jdo\listener\InstanceLifecycleListener.java Sende api20\src\java\javax\jdo\listener\LoadLifecycleListener.java Sende api20\src\java\javax\jdo\listener\StoreLifecycleListener.java Sende api20\src\java\javax\jdo\spi\I18NHelper.java Sende api20\src\java\javax\jdo\spi\JDOImplHelper.java Sende api20\src\java\javax\jdo\spi\JDOPermission.java Sende api20\src\java\javax\jdo\spi\PersistenceCapable.java Sende api20\src\java\javax\jdo\spi\StateInterrogation.java Sende api20\src\java\javax\jdo\spi\StateManager.java ?\195?\156bertrage Daten ............................. Revision 389615 ?\195?\188bertragen.